Code review comment for ~sajoupa/charm-telegraf:add_ip_range_support

Revision history for this message
Paul Goins (vultaire) wrote :

Just a quick note in passing so far:

* Generally looks good
* I need to take a proper look at the tests for this later, unit and functional - it seems sane, but I likely need more context than I'm seeing here to properly review. I'll try to come back to this when I have more time.

Left one minor code comment re: code which could be done in less lines.

« Back to merge proposal