Telegraf Charm

Code review comment for ~sajoupa/charm-telegraf:plugins-when-telegraf-installed

  1. Git
  2. lp:~sajoupa/charm-telegraf
  3. plugins-when-telegraf-installed
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

Change looks good (no missing @when state in other functions). However, since the MP was proposed, the charm has been restructured and reactive/telegraf.py is now located in src/reactive/telegraf.py. Sorry for that. Could you rebase it against master so I can run the same "make test" you did and approve it?

Thank you.

review: Needs Fixing

« Back to merge proposal