Code review comment for lp:~saiarcot895/ubuntu/utopic/openscenegraph/armhf-support

Revision history for this message
Saikrishna Arcot (saiarcot895) wrote :

In commit 42, there is a build error with regards to typedef'ing GLdouble if it isn't defined. Openscenegraph typedefs it to double, while Qt typedefs it to GLfloat (which will be a float). Because of this, a build error occurs. In addition, Qt uses checks if GLdouble is defined using #ifndef, which returns true (that it's not defined), since the typedef doesn't affect #defines.

« Back to merge proposal