Merge ~sahnaseredini/ubuntu-cve-tracker:amir-dev into ubuntu-cve-tracker:master

[Amir Naseredini]

Changing the relative addresses to absolute addresses

There are some cases where a relative address is used in scripts/pkg_history
and scripts/pkg_status which doesn't let the code to run correctly everywhere.
This PR proposes the changes required to change the relative addresses to
absolute addresses in order to solve the issue.

[Spyros Seimenis (sespiros)]

Hey Amir, thanks for the fixes. pkg_history might need an extra change as as it is, it would break for people using it with shells that are not bash (due to "BASH_SOURCE" missing). For example I am on zsh and I get:

scripts/pkg_history: 13: Bad substitution
dirname: missing operand

A workaround would be to simply change the shebang at the top of the pkg_history script to explicitly invoke #!/usr/bin/bash rather than #!/bin/sh (which is linked to dash in Ubuntu). pkg_status already uses #!/bin/bash and I see most scripts in UCT do the same so I guess that would be fine.

Apparently this seems like one of those rabbit-hole issues if you wanted to do that while still being POSIX compliant i.e check out https://stackoverflow.com/questions/29832037/how-to-get-script-directory-in-posix-sh

review: Needs Fixing

[Amir Naseredini (sahnaseredini)]

Hey Spyros, thanks for the review and comments. I made the following change:

* changed the shebang to invoke bash

Let me know what you think. Thanks

[Spyros Seimenis (sespiros)]

review: Approve

diff --git a/scripts/pkg_history b/scripts/pkg_history
index 8bc0677..022ce2d 100755
--- a/scripts/pkg_history
+++ b/scripts/pkg_history
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 # Author: Jamie Strandboge <[e-mail]>
 # Copyright (C) 2013 Canonical Ltd.
@@ -9,6 +9,9 @@
 
 set -e
 
+# finding ubuntu-cve-tracker
+UCT_DIR="$( dirname $( dirname "${BASH_SOURCE[0]}" ))"
+
 showfull="no"
 release=
 showstatus="no"
@@ -59,17 +62,19 @@ for pkg in "$@"; do
     	dirs="active"
     fi
     for d in ${dirs} ; do
-        for cve in `grep "$pattern" ./$d/CVE-* | \
+        for cve in `grep "$pattern" "${UCT_DIR}/${d}/CVE-"* | \
             cut -d ':' -f 1 | \
-            cut -d '/' -f 3 | \
+            rev | \
+            cut -d '/' -f 1 | \
+            rev | \
             sort -u` ; do
             if [ "$showfull" = "yes" ]; then
                 echo ""
-                cat "./$d/$cve"
+                cat "${UCT_DIR}/$d/$cve"
                 echo ""
             else
                 if [ "$showstatus" = "yes" ]; then
-                    status=$(grep "^$pattern" "./${d}/${cve}" | cut -d ':' -f 2-)
+                    status=$(grep "^$pattern" "${UCT_DIR}/${d}/${cve}" | cut -d ':' -f 2-)
                     echo "${cve}${status}"
                 else
                     echo "$cve"
diff --git a/scripts/pkg_status b/scripts/pkg_status
index 78fe49b..87f218a 100755
--- a/scripts/pkg_status
+++ b/scripts/pkg_status
@@ -11,6 +11,9 @@
 set -e
 set -o pipefail
 
+# finding ubuntu-cve-tracker
+UCT_DIR="$( dirname $( dirname "${BASH_SOURCE[0]}" ))"
+
 #
 # Usage:
 # ./scripts/pkg_status pkgname1 pkgname2 ...
@@ -54,10 +57,10 @@ for p in "$@"; do
 	pkgs="${pkgs} -p ${p}"
 done
 if [ "$showfull" = "yes" ]; then
-	CVES=$(./scripts/ubuntu-table $only_release $skip_esm $subproject $assigned $released_info --supported $nvd $pkgs 2>/dev/null | sort -k 2 | grep -v '^ ' | awk '{print $1}')
-	echo "$CVES" | xargs ./scripts/cve_status -f
+	CVES=$(${UCT_DIR}/scripts/ubuntu-table $only_release $skip_esm $subproject $assigned $released_info --supported $nvd $pkgs 2>/dev/null | sort -k 2 | grep -v '^ ' | awk '{print $1}')
+	echo "$CVES" | xargs ${UCT_DIR}/scripts/cve_status -f
 else
-	REPORT=$(./scripts/ubuntu-table $only_release $skip_esm $subproject $assigned $released_info --supported $nvd $pkgs 2>/dev/null)
+	REPORT=$(${UCT_DIR}/scripts/ubuntu-table $only_release $skip_esm $subproject $assigned $released_info --supported $nvd $pkgs 2>/dev/null)
 	if [ -n "$REPORT" ]; then
 		echo "$REPORT" | head -n1
 		echo "$REPORT" | tail -n +2 | sort -n