Code review comment for lp:~s3734770/widelands/carli-ai
Revision history for this message
| SirVer (sirver) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Shouldnt the road optimizer detect the flag problems? I did not notice any
> problems with that.
It should, but notice the comment in 256. I guess it is there for a reason.
> About the compile.sh.... the make parameters should not be versioned.
Yep, it shouldn't. You have to be more careful what you commit. You can unmerge your changes or rely on me reverting it when this will be merged.
> But not the dismantle. It works for me. Which version of widelands do you
> have?
Current trunk obviously :). I am really reluctant to merge this for it is not clear what you did. Your branch contains a lot of lines where only whitespace changes happened (something which you should avoid. Use bzr diff or qdiff or similar to check that you do not do that). Some stuff is juggled around and in some places you changed one magic constant into another. What makes you believe that your AI is indeed an improvement?