Merge lp:~s-parkinson11/fluidity/DG_BR_PartialStressForm into lp:fluidity

[Samuel Parkinson]

Added a simple implementation for the partial stress form in DG using the bassi-rebay formulation. This only works for isotropic viscosities.

[Samuel Parkinson (s-parkinson11)]

This hasn't gone through buildbot yet. I will post on here when it passes.

[Tim Greaves (tim-greaves)]

Now in buildbot and running:

 http://buildbot.ese.ic.ac.uk:8080/builders/DG_BR_PartialStressForm

[Samuel Parkinson (s-parkinson11)]

now green on buildbot

[lp:~s-parkinson11/fluidity/DG_BR_PartialStressForm]

4220. By Samuel Parkinson on 2013-05-29

changes following review

4221. By Samuel Parkinson on 2013-05-29

fixes to manual entry

4222. By Samuel Parkinson on 2013-05-30

fix memory allocation routine to match new schema and tidy up test

[Samuel Parkinson (s-parkinson11)]

Stephan,

I think I have addressed all of the issues we looked at:
1) change how partial_stress logical is initialised
2) add some more comments in the bassi-rebay assemble routine to describe what the A matrix is and about the assumption of isotropic viscosity
3) add options checking to ensure bassi-rebay is selected when using partial stress
4) change schema to be consistent with CG

Is this ready to go now?

[Stephan Kramer (s-kramer)]

Looks great. I think you still need to do a 'update_options' after your schema change. Which brings me to one last question what happens if people run a not-updated .flml without viscosity_scheme/tensor_form? Does it default to tensor_form indeed?

review: Approve

[Samuel Parkinson (s-parkinson11)]

Yes I did need to run update_options, good spot. Buildbot failed on diamond validation.

Default is tensor form. I have updated the flml in tests, examples, and longtests, I will run it through buildbot and then merge.

Thanks for the review. I'll get on to looking at yours now.

[lp:~s-parkinson11/fluidity/DG_BR_PartialStressForm]

4223. By Samuel Parkinson on 2013-05-30

fix flml files for diamond validation

4224. By Samuel Parkinson on 2013-05-31

merge with trunk