Code review comment for lp:~rye/ubuntuone-client/stop-killing-thumbnails

Revision history for this message
Roman Yepishev (rye) wrote :

Reversed the order of the statements for the first item.

Unfortunately, it is not possible to call any destroy callback routine with custom arguments when uon->observer is destroyed. The callback accepts value pointer only and therefore our uon object cannot be easily accessed.

It is possible to add code that runs through the hash and removes all references, however it looks like nautilus keeps additional reference to NAUTILUS_TYPE_INFO_PROVIDER module (looks like ubuntuone-nautilus and nautilus-share are affected). Our shutdown and finalize routines are never called so I would rather not write code blindly :)

I am investigating this nautilus bug at the moment and will file a bug when I get some useful info.

« Back to merge proposal