Merge lp:~rye/ubuntu/natty/bindwood/update-firefox-6-compat-fix into lp:ubuntu/natty/bindwood

Proposed by Roman Yepishev
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~rye/ubuntu/natty/bindwood/update-firefox-6-compat-fix
Merge into: lp:ubuntu/natty/bindwood
Diff against target: 60 lines (+42/-0)
3 files modified
debian/changelog (+14/-0)
debian/patches/firefox_6_compat.patch (+27/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~rye/ubuntu/natty/bindwood/update-firefox-6-compat-fix
Reviewer Review Type Date Requested Status
Micah Gersten (community) Disapprove
Ubuntu branches Pending
Review via email: mp+76055@code.launchpad.net

Commit message

Updated the patch using the fix in trunk

Description of the change

Updated the patch using the code from bindwood trunk. The former patch had a bug in it.

To post a comment you must log in.
Revision history for this message
Micah Gersten (micahg) wrote :

This will end up in ppa:ubuntu-mozilla-security/ppa in a few hours and be pushed out. I'm using the version that Chris Coulson pushed to firefox-beta with your changes.

review: Disapprove
Revision history for this message
Micah Gersten (micahg) wrote :

Sorry, will be pushed out on release day with Firefox 7.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

This has been pushed out. Could you please change the merge proposal status? Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-16 14:44:28 +0000
+++ debian/changelog 2011-09-19 15:57:26 +0000
@@ -1,3 +1,17 @@
1bindwood (1.99.0-0ubuntu1.2) natty-proposed; urgency=low
2
3 * Updated debian/patches/firefox_6_compat.patch (LP: #789107)
4
5 -- Roman Yepishev <roman.yepishev@canonical.com> Mon, 19 Sep 2011 15:25:41 +0000
6
7bindwood (1.99.0-0ubuntu1.1) natty-security; urgency=low
8
9 * Add support for Firefox 6: (LP: #798484)
10 - bump maxVersion to 6.0.*
11 - don't use "class" as a variable name, as it's a reserved keyword
12
13 -- Chris Coulson <chris.coulson@canonical.com> Fri, 17 Jun 2011 04:34:13 -0500
14
1bindwood (1.99.0-0ubuntu1) natty; urgency=low15bindwood (1.99.0-0ubuntu1) natty; urgency=low
216
3 * New upstream release.17 * New upstream release.
418
=== added file 'debian/patches/firefox_6_compat.patch'
--- debian/patches/firefox_6_compat.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/firefox_6_compat.patch 2011-09-19 15:57:26 +0000
@@ -0,0 +1,27 @@
1--- a/install.rdf 2011-03-09 01:46:26 +0000
2+++ b/install.rdf 2011-05-26 12:39:13 +0000
3@@ -18,7 +18,7 @@
4 <Description>
5 <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
6 <em:minVersion>3.5</em:minVersion>
7- <em:maxVersion>4.0.*</em:maxVersion>
8+ <em:maxVersion>6.0.*</em:maxVersion>
9 </Description>
10 </em:targetApplication>
11
12
13--- a/modules/couch.jsm 2011-02-28 15:24:11 +0000
14+++ b/modules/couch.jsm 2011-05-26 12:38:50 +0000
15@@ -13,9 +13,8 @@
16 var EXPORTED_SYMBOLS = ["CouchDB", "XMLHttpRequest"];
17
18 var XMLHttpRequest = function () {
19- var class = "@mozilla.org/xmlextras/xmlhttprequest;1";
20- var service = Components.interfaces.nsIXMLHttpRequest;
21- return Components.classes[class].getService(service);
22+ return Components.classes["@mozilla.org/xmlextras/xmlhttprequest;1"].
23+ getService(Components.interfaces.nsIXMLHttpRequest);
24 }
25
26 // A simple class to represent a database. Uses XMLHttpRequest to interface with
27
028
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-03-16 14:44:28 +0000
+++ debian/patches/series 2011-09-19 15:57:26 +0000
@@ -1,1 +1,2 @@
1# Quilt patch series1# Quilt patch series
2firefox_6_compat.patch

Subscribers

People subscribed via source and target branches