VM

Merge lp:~ryanakca/vm/vm-move-after-reading into lp:vm

Proposed by Ryan Kavanagh
Status: Merged
Merged at revision: 1485
Proposed branch: lp:~ryanakca/vm/vm-move-after-reading
Merge into: lp:vm
Diff against target: 82 lines (+33/-13)
3 files modified
info/vm.texinfo (+5/-3)
lisp/vm-folder.el (+16/-10)
lisp/vm-vars.el (+12/-0)
To merge this branch: bzr merge lp:~ryanakca/vm/vm-move-after-reading
Reviewer Review Type Date Requested Status
Uday Reddy Approve
Review via email: mp+151987@code.launchpad.net

Description of the change

Add variable to enable vm to move to the next message after marking one as read, similar to vm-move-after-delete .

To post a comment you must log in.
1485. By Ryan Kavanagh

Add support for vm-move-after-reading

Revision history for this message
Ryan Kavanagh (ryanakca) wrote :

Sorry, "bzr revert -n ...." didn't behave as I expected to and I mistakenly included the install-info patch.

Revision history for this message
Uday Reddy (reddyuday) wrote :

This is a good idea. Thanks for implementing it!

I didn't find any install-info changes. So, it was ok.

Revision history for this message
Uday Reddy (reddyuday) wrote :

Merging it with some additional corrections.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'info/vm.texinfo'
--- info/vm.texinfo 2013-02-15 08:44:48 +0000
+++ info/vm.texinfo 2013-03-06 15:29:23 +0000
@@ -1898,11 +1898,13 @@
1898@findex vm-mark-message-unread1898@findex vm-mark-message-unread
1899@kindex U1899@kindex U
1900@kindex .1900@kindex .
1901@vindex vm-move-after-reading
1901You can ``unread'' a message (so to speak) by typing @kbd{U}1902You can ``unread'' a message (so to speak) by typing @kbd{U}
1902(@code{vm-unread-message}, also called @code{vm-mark-message-unread}).1903(@code{vm-unread-message}, also called @code{vm-mark-message-unread}).
1903The current message will be marked unread. Conversely, you can mark1904The current message will be marked unread. Conversely, you can mark an
1904an unread message as read by typing @kbd{.}1905unread message as read by typing @kbd{.} (@code{vm-mark-message-read}).
1905(@code{vm-mark-message-read}).1906Setting the variable @var{vm-move-after-reading} will cause vm to move
1907to the next undeleted message after marking the current message as read.
19061908
1907@findex vm-toggle-flag-message1909@findex vm-toggle-flag-message
1908@kindex !1910@kindex !
19091911
=== modified file 'lisp/vm-folder.el'
--- lisp/vm-folder.el 2013-01-02 21:38:39 +0000
+++ lisp/vm-folder.el 2013-03-06 15:29:23 +0000
@@ -3253,18 +3253,24 @@
3253thread are affected."3253thread are affected."
3254 (interactive "p")3254 (interactive "p")
3255 (or count (setq count 1))3255 (or count (setq count 1))
3256 (vm-follow-summary-cursor)3256 (let ((used-marks (eq last-command 'vm-next-command-uses-marks))
3257 (vm-select-folder-buffer-and-validate 1 (vm-interactive-p))3257 (del-count 0))
3258 (let ((mlist (vm-select-operable-messages3258 (vm-follow-summary-cursor)
3259 count (vm-interactive-p) "Mark as read")))3259 (vm-select-folder-buffer-and-validate 1 (vm-interactive-p))
3260 (while mlist3260 (let ((mlist (vm-select-operable-messages
3261 (when (or (vm-unread-flag (car mlist))3261 count (vm-interactive-p) "Mark as read")))
3262 (vm-new-flag (car mlist)))3262 (while mlist
3263 (when (or (vm-unread-flag (car mlist))
3264 (vm-new-flag (car mlist)))
3263 (vm-set-unread-flag (car mlist) nil)3265 (vm-set-unread-flag (car mlist) nil)
3264 (vm-set-new-flag (car mlist) nil))3266 (vm-set-new-flag (car mlist) nil))
3265 (setq mlist (cdr mlist))))3267 (setq mlist (cdr mlist))))
3266 (vm-display nil nil '(vm-mark-message-read) '(vm-mark-message-read))3268 (vm-display nil nil '(vm-mark-message-read) '(vm-mark-message-read))
3267 (vm-update-summary-and-mode-line))3269 (vm-update-summary-and-mode-line)
3270 (when (and vm-move-after-reading (not used-marks))
3271 (let ((vm-circular-folders (and vm-circular-folders
3272 (eq vm-move-after-deleting t))))
3273 (vm-next-message count t executing-kbd-macro)))))
3268(defalias 'vm-flag-message-read 'vm-mark-message-read)3274(defalias 'vm-flag-message-read 'vm-mark-message-read)
3269(make-obsolete 'vm-flag-message-read 3275(make-obsolete 'vm-flag-message-read
3270 'vm-mark-message-read "8.2.0")3276 'vm-mark-message-read "8.2.0")
32713277
=== modified file 'lisp/vm-vars.el'
--- lisp/vm-vars.el 2013-02-12 00:09:02 +0000
+++ lisp/vm-vars.el 2013-03-06 15:29:23 +0000
@@ -4733,6 +4733,18 @@
4733 (const :tag "Yes" t) 4733 (const :tag "Yes" t)
4734 (const :tag "Skip if some undeleted" skip-if-some-undeleted)))4734 (const :tag "Skip if some undeleted" skip-if-some-undeleted)))
47354735
4736(defcustom vm-move-after-reading nil
4737 "*Non-nil value causes VM's `.' command to automatically invoke
4738`vm-next-message' or `vm-previous-message' after killing messages, to try
4739to move past the read messages. A value of t means motion
4740should honor the value of `vm-circular-folders'. A value that is
4741not t and not nil means that motion should be done as if
4742`vm-circular-folders' is set to nil."
4743 :group 'vm-summary
4744 :type '(choice (const :tag "No" nil)
4745 (const :tag "Yes" t)
4746 (const :tag "Skip if some undeleted" skip-if-some-undeleted)))
4747
4736(defcustom vm-delete-after-saving nil4748(defcustom vm-delete-after-saving nil
4737 "*Non-nil value causes VM automatically to mark messages for deletion4749 "*Non-nil value causes VM automatically to mark messages for deletion
4738after successfully saving them to a folder."4750after successfully saving them to a folder."

Subscribers

People subscribed via source and target branches

to all changes: