Code review comment for lp:~rvb/maas/update-sst

Revision history for this message
Gavin Panella (allenap) wrote :

\o/

[1]

+ project_home = os.path.dirname(
+ os.path.dirname(os.path.dirname(os.path.dirname(__file__))))

There's a slightly more succinct way of doing this:

        from os.path import join, pardir, dirname
        project_home = join(pardir, pardir, pardir, dirname(__file__))

Also, I tend to import from os.path, or path from os, though that's no
reason you should too. I'm too lazy to type or read os.path.thing all
the time :)

review: Approve

« Back to merge proposal