Code review comment for lp:~rvb/maas/sudo-mipf

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> Yup, that needs root! I wasn't aware of mock.ANY -- it solves a problem that
> I've been wondering about for some time.
>
> One question: can you think of any situations where the difference between
> "maas-import-pxe-files" (in the script invocation) and "/usr/sbin/maas-import-
> pxe-files" (in the sudoers file) might cause trouble?

Not really. I think this is the right thing to do:
- the sudo rule allows one to run /usr/sbin/maas-import-pxe-files, which is the script that the package installs.
- the code simply calls 'maas-import-pxe-files', thus allowing the user to override the script if he wants to.

« Back to merge proposal