Code review comment for lp:~rvb/maas/show-version-doc

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> [1]
>
> +bzr_last_revision_number = check_output(['bzr', 'revno'])
> +bzr_last_revision_date = check_output(['bzr', 'version-info', '--
> template={date}','--custom'])
> +bzr_build_date = check_output(['bzr', 'version-info', '--
> template={build_date}','--custom'])
>
> Space after commas.

Right, done.

> Strip whitespace from the outputs too?

Why? The dates are fine as bzr outputs them I think.

> [2]
>
> It would be good to have the branch name too. Short name (i.e. lp...)
> would be best, but I don't know if that's easy to get out of bzr.

I agree, but I don't know how to get that. More importantly, I'm not sure this information is always available depending on how you created the branch.

« Back to merge proposal