Code review comment for lp:~rvb/maas/show-version-doc

Revision history for this message
Gavin Panella (allenap) wrote :

[1]

+bzr_last_revision_number = check_output(['bzr', 'revno'])
+bzr_last_revision_date = check_output(['bzr', 'version-info', '--template={date}','--custom'])
+bzr_build_date = check_output(['bzr', 'version-info', '--template={build_date}','--custom'])

Space after commas.

Strip whitespace from the outputs too?

[2]

It would be good to have the branch name too. Short name (i.e. lp...)
would be best, but I don't know if that's easy to get out of bzr.

review: Approve

« Back to merge proposal