Code review comment for lp:~rvb/maas/retry-with-files

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> This is good, and it should land.
>
> I did have a thought about it while reviewing. I'm a little concerned about
> the use (internally) of NamedTemporaryFile, and how copies of it will behave.
> I put together an incomplete alternative, which resets the input stream at the
> WSGI level: http://paste.ubuntu.com/10671243/

You're right, your solution is better. I've tested it manually and added a test case for it (it's a bit painful to fake a proper WSGIRequest!).

« Back to merge proposal