Code review comment for lp:~rvb/maas/retry-power-changes

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Sunday 27 Jul 2014 11:47:18 you wrote:
> Same here, mark_node_broken() does not exist.
>
> I think this highlights a shortcoming with using Mock: it lets you do
> anything. A couple of things come to mind that might help here:
>
> 1. Don't mock the whole client object, just mock __call__.
> 2. Use mock.create_autospec() to create mocks that only all things that the
> underlying implementation does (so you can mock the whole client).

*cough* end-to-end fixture *cough*

« Back to merge proposal