Code review comment for lp:~rvb/maas/retry-power-changes

Revision history for this message
Julian Edwards (julian-edwards) wrote :

 review: approve

On Thursday 24 Jul 2014 10:36:00 you wrote:
> Turns out simply using 'yield power.change_power_state(…, clock=clock)'
> (instead of calling clock.callLater) is enough to remove the
> clock.advance(0.1). I /think/ this is due to the fact that all the waiting
> done inside power.change_power_state is using the clock that you pass to
> the method so the initial yield ensures the first run is done (and thus the
> first check succeeds) and after that, you can control the waiting by using
> clock.advance.

\o/

Awesome.

review: Approve

« Back to merge proposal