Merge lp:~rvb/maas/packaging.proxy-bug-1081229 into lp:~maas-maintainers/maas/packaging

Proposed by Raphaël Badin
Status: Merged
Merged at revision: 147
Proposed branch: lp:~rvb/maas/packaging.proxy-bug-1081229
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 22 lines (+4/-1)
2 files modified
debian/changelog (+3/-0)
debian/extras/99-maas-sudoers (+1/-1)
To merge this branch: bzr merge lp:~rvb/maas/packaging.proxy-bug-1081229
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+135361@code.launchpad.net

Commit message

Update the sudo rule to allow preserving the environment when calling maas-import-pxe-files via sudo. We need this to preserve variables like 'http{,s}_proxy'.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Looks good. As discussed on the call this morning, it's a bug that maas-import-pxe-files runs as root, but we can address that separately.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-13 20:40:07 +0000
3+++ debian/changelog 2012-11-21 10:31:20 +0000
4@@ -1,6 +1,9 @@
5 maas (0.1+bzr1269+dfsg-0ubuntu2) UNRELEASED; urgency=low
6
7 [ Raphaël Badin ]
8+ * debian/extras/99-maas-sudoers: Add 'SETENV:' to sudo rule
9+ to allow preserving the environment when running
10+ /usr/sbin/maas-import-pxe-files via sudo.
11 * debian/maas-dns.postinst: fix permissions and group ownership of
12 file /etc/bind/maas/named.conf.rndc.maas. (LP: #1066935)
13 * debian/control: Remove the dependency of maas-cluster-controller
14
15=== modified file 'debian/extras/99-maas-sudoers'
16--- debian/extras/99-maas-sudoers 2012-11-05 11:52:52 +0000
17+++ debian/extras/99-maas-sudoers 2012-11-21 10:31:20 +0000
18@@ -1,3 +1,3 @@
19 maas ALL= NOPASSWD: /usr/sbin/service maas-dhcp-server restart
20 maas ALL= NOPASSWD: /usr/sbin/maas-provision
21-maas ALL= NOPASSWD: /usr/sbin/maas-import-pxe-files
22+maas ALL= NOPASSWD: SETENV: /usr/sbin/maas-import-pxe-files

Subscribers

People subscribed via source and target branches