Code review comment for lp:~rvb/maas/maas-longpoll-fix

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Hi Raphaël,

Thank you very much for this fix, and the clarification of LONGPOLL_PATH, and the additional tests.

But unless I'm reading things incorrectly, we still don't have any tests that ensure that the view is setup correctly, right? We have tests get get_proxy_longpoll_enabled() is implemented correctly, but no tests that ensure that the proxy view is set up correctly? I assume we have unit tests that the view itself work properly.

« Back to merge proposal