Merge lp:~rvb/maas/fix-etc-hosts-bug-1087183-2 into lp:~maas-committers/maas/trunk

[Raphaël Badin]

Use the default /etc/hosts/ instead of having cloud-init override it.

For a long discussion about why we need this change, see the related bug. In short: we want dns_resolve(hostname) to return the node's IP address instead of 127.0.0.1.

Packages built using this branch are available for testing in https://code.launchpad.net/~rvb/+archive/ubuntu/maas.

[Graham Binns (gmb)]

review: Approve

[Raphaël Badin (rvb)]

I'm not landing this just now as we want people to test it first.

fwiw, this is what happens on a deployed node with the current config: http://paste.ubuntu.com/8473237/

This is what happens with this change: http://paste.ubuntu.com/8473238/

The only difference is on the last line.

[Andres Rodriguez (andreserl)]

Lets aslk the Landscape team to test this please!
On Oct 1, 2014 4:26 PM, "Raphaël Badin" <email address hidden> wrote:

> The proposal to merge lp:~rvb/maas/fix-etc-hosts-bug-1087183-2 into
> lp:maas has been updated.
>
> Description changed to:
>
> For a long discussion about why we need this change, see the related bug.
> In short: we want dns_resolve(hostname) to return the node's IP address
> instead of 127.0.0.1.
>
> Packages built using this branch are available for testing in
> https://code.launchpad.net/~rvb/+archive/ubuntu/maas.
>
> For more details, see:
>
> https://code.launchpad.net/~rvb/maas/fix-etc-hosts-bug-1087183-2/+merge/236709
> --
>
> https://code.launchpad.net/~rvb/maas/fix-etc-hosts-bug-1087183-2/+merge/236709
> You are subscribed to branch lp:maas.
>

[Andreas Hasenack (ahasenack)]

I couldn't get nodes to work, see https://bugs.launchpad.net/maas/+bug/1378479

[Andreas Hasenack (ahasenack)]

Bug was marked as invalid, because this code isn't merged yet, but it has the details.

[Christian Reis (kiko)]

Andreas retested later with the beta in the testing PPA:

<andreas> kiko: so, https://bugs.launchpad.net/maas/+bug/1378479 also happened with a fresh install from the testing ppa. Can't get a working node.

The symptom is as he described in bug 1378479; basically networking comes up dead. It feels to me like it's actually an unrelated issue, given that the beta version works. I'll ask for more information in the bug.

[Christian Reis (kiko)]

I will deploy your PPA branch tomorrow and will report back on what the effect was.

[Andreas Hasenack (ahasenack)]

https://bugs.launchpad.net/maas/+bug/1378479 has all the latest. I reproduced it on a brand new maas installation first by installing an older version and confirming maas works. Then I upgraded to the version in the testing ppa and it broke. I believe it's not related to the change in this MP, you just happen to have branched off a trunk version that had the problem already. But until that is fixed, I can't verify it for you.

[Raphaël Badin (rvb)]

1379591 is fixed now. I just merged trunk into my lp:~rvb/maas/fix-etc-hosts-bug-1087183-2/ branch. The new packages are available in https://code.launchpad.net/~rvb/+archive/ubuntu/maas.

[Andreas Hasenack (ahasenack)]

Ok, I will give it a run

[Andreas Hasenack (ahasenack)]

The package in maas-maintainers/experimental is more recent than yours, fyi.
     1.7.0~beta6+bzr3246-0ubuntu1~trusty1 0
        500 http://ppa.launchpad.net/maas-maintainers/experimental/ubuntu/ trusty/main amd64 Packages

     1.7.0~beta5+bzr3199+3166+318~ppa0~ubuntu14.04.1 0
        500 http://ppa.launchpad.net/rvb/maas/ubuntu/ trusty/main amd64 Packages

And I have 1.7.0~beta6+bzr3232-0ubuntu1~trusty1 installed. I'll try a downgrade.

[Andreas Hasenack (ahasenack)]

Got some oopses during a deployment, not sure if related to the changes in this branch:

https://pastebin.canonical.com/118726/

[Gavin Panella (allenap)]

> Got some oopses during a deployment, not sure if related to the
> changes in this branch:
>
> https://pastebin.canonical.com/118726/

I think you can ignore these. This code hasn't changed in an age so it's almost certainly not related.

[Gavin Panella (allenap)]

Filed as bug 1381129.

[Raphaël Badin (rvb)]

> The package in maas-maintainers/experimental is more recent than yours, fyi.

Arg, rebuilding packages now…

[Andreas Hasenack (ahasenack)]

I deployed Landscape using this version of MAAS into containers on node 0, and all worked fine (including rabbitmq-server, notoriously picky about hostnames). I cannot test a cloud installer yet, since we are in a sprint week and people might need to demo a cloud in a hurry, so I can't risk breaking our MAAS clusters this week.

I also of course verified that /etc/hosts does NOT have the 127.0.1.1 entry.

[Christian Reis (kiko)]

Merge it.

review: Approve

[Raphaël Badin (rvb)]

Thanks for testing this Andreas!

=== modified file 'src/maasserver/compose_preseed.py'
--- src/maasserver/compose_preseed.py	2014-08-17 10:42:28 +0000
+++ src/maasserver/compose_preseed.py	2014-10-14 15:50:53 +0000
@@ -37,7 +37,11 @@
         })
 
     local_config_yaml = yaml.safe_dump({
-        "manage_etc_hosts": "localhost",
+        # Do not let cloud-init override /etc/hosts/: use the default
+        # behavior which means running `dns_resolve(hostname)` on a node
+        # will query the DNS server (and not return 127.0.0.1).
+        # See bug 1087183 for details.
+        "manage_etc_hosts": False,
         "apt_preserve_sources_list": True,
     })
     # this is debconf escaping

=== modified file 'src/maasserver/tests/test_compose_preseed.py'
--- src/maasserver/tests/test_compose_preseed.py	2014-09-20 15:42:12 +0000
+++ src/maasserver/tests/test_compose_preseed.py	2014-10-14 15:50:53 +0000
@@ -115,7 +115,7 @@
         data = yaml.safe_load(value)
 
         self.assertIn("manage_etc_hosts", data)
-        self.assertEqual(data["manage_etc_hosts"], "localhost")
+        self.assertEqual(data["manage_etc_hosts"], False)
         self.assertIn("apt_preserve_sources_list", data)
         self.assertEqual(data["apt_preserve_sources_list"], True)