1
=== modified file 'src/maasserver/api/tests/test_version.py'
2
--- src/maasserver/api/tests/test_version.py	2014-08-18 13:23:21 +0000
3
+++ src/maasserver/api/tests/test_version.py	2015-04-08 15:11:40 +0000
4
@@ -21,6 +21,7 @@
5
21
from django.core.urlresolvers import reverse
21
from django.core.urlresolvers import reverse
6
22
from maasserver.api.version import API_CAPABILITIES_LIST
22
from maasserver.api.version import API_CAPABILITIES_LIST
7
23
from maasserver.testing.testcase import MAASServerTestCase
23
from maasserver.testing.testcase import MAASServerTestCase
8
24
from maasserver.utils import version as version_module
9
24
25
10
25
26
11
26
class TestFindingResources(MAASServerTestCase):
27
class TestFindingResources(MAASServerTestCase):
12
@@ -31,6 +32,10 @@
13
31
            '/api/1.0/version/', reverse('version'))
32
            '/api/1.0/version/', reverse('version'))
14
32
33
15
33
    def test_GET_returns_details(self):
34
    def test_GET_returns_details(self):
16
35
        mock_apt = self.patch(version_module, "get_version_from_apt")
17
36
        mock_apt.return_value = "1.8.0~alpha4+bzr356-0ubuntu1"
18
37
        self.patch(version_module, "_cache", {})
19
38
20
34
        response = self.client.get(reverse('version'))
39
        response = self.client.get(reverse('version'))
21
35
        self.assertEqual(httplib.OK, response.status_code)
40
        self.assertEqual(httplib.OK, response.status_code)
22
36
41
23
@@ -38,5 +43,7 @@
24
38
        self.assertEqual(
43
        self.assertEqual(
25
39
            {
44
            {
26
40
                'capabilities': API_CAPABILITIES_LIST,
45
                'capabilities': API_CAPABILITIES_LIST,
27
46
                'version': '1.8.0',
28
47
                'subversion': 'alpha4+bzr356',
29
41
            },
48
            },
30
42
            parsed_result)
49
            parsed_result)
31
43
50
32
=== modified file 'src/maasserver/api/version.py'
33
--- src/maasserver/api/version.py	2014-09-17 02:17:35 +0000
34
+++ src/maasserver/api/version.py	2015-04-08 15:11:40 +0000
35
@@ -20,6 +20,7 @@
36
20
20
37
21
from django.http import HttpResponse
21
from django.http import HttpResponse
38
22
from maasserver.api.support import AnonymousOperationsHandler
22
from maasserver.api.support import AnonymousOperationsHandler
39
23
from maasserver.utils.version import get_maas_version_subversion
40
23
24
41
24
# MAAS capabilities. See docs/capabilities.rst for documentation.
25
# MAAS capabilities. See docs/capabilities.rst for documentation.
42
25
CAP_NETWORKS_MANAGEMENT = 'networks-management'
26
CAP_NETWORKS_MANAGEMENT = 'networks-management'
43
@@ -39,6 +40,8 @@
44
39
    This returns a JSON dictionary with information about this
40
    This returns a JSON dictionary with information about this
45
40
    MAAS instance.
41
    MAAS instance.
46
41
    {
42
    {
47
43
        'version': '1.8.0',
48
44
        'subversion': 'alpha10+bzr3750',
49
42
        'capabilities': ['capability1', 'capability2', ...]
45
        'capabilities': ['capability1', 'capability2', ...]
50
43
    }
46
    }
51
44
    """
47
    """
52
@@ -46,8 +49,12 @@
53
46
    create = update = delete = None
49
    create = update = delete = None
54
47
50
55
48
    def read(self, request):
51
    def read(self, request):
56
52
        version, subversion = get_maas_version_subversion()
57
49
        version_info = {
53
        version_info = {
58
50
            'capabilities': API_CAPABILITIES_LIST,
54
            'capabilities': API_CAPABILITIES_LIST,
59
55
            'version': version,
60
56
            'subversion': subversion,
61
57
62
51
        }
58
        }
63
52
        return HttpResponse(
59
        return HttpResponse(
64
53
            version_info, mimetype='application/json; charset=utf-8',
60
            version_info, mimetype='application/json; charset=utf-8',
65
54
61
66
=== modified file 'src/maasserver/context_processors.py'
67
--- src/maasserver/context_processors.py	2015-04-02 14:18:18 +0000
68
+++ src/maasserver/context_processors.py	2015-04-08 15:11:40 +0000
69
@@ -23,7 +23,7 @@
70
23
from maasserver.models import Config
23
from maasserver.models import Config
71
24
from maasserver.utils.version import (
24
from maasserver.utils.version import (
72
25
    get_maas_doc_version,
25
    get_maas_doc_version,
74
26
    get_maas_version,
26
    get_maas_version_ui,
75
27
)
27
)
76
28
28
77
29
29
78
@@ -88,6 +88,6 @@
79
88
            'site_name': Config.objects.get_config('maas_name'),
88
            'site_name': Config.objects.get_config('maas_name'),
80
89
        },
89
        },
81
90
        'debug': settings.DEBUG,
90
        'debug': settings.DEBUG,
83
91
        'version': get_maas_version(),
91
        'version': get_maas_version_ui(),
84
92
        'doc_version': get_maas_doc_version(),
92
        'doc_version': get_maas_doc_version(),
85
93
    }
93
    }
86
94
94
87
=== modified file 'src/maasserver/utils/tests/test_version.py'
88
--- src/maasserver/utils/tests/test_version.py	2015-03-30 19:38:57 +0000
89
+++ src/maasserver/utils/tests/test_version.py	2015-04-08 15:11:40 +0000
90
@@ -63,64 +63,6 @@
91
63
            version.get_version_from_apt(version.REGION_PACKAGE_NAME))
63
            version.get_version_from_apt(version.REGION_PACKAGE_NAME))
92
64
64
93
65
65
94
66
class TestFormatVersion(MAASTestCase):
95
67
96
68
    scenarios = [
97
69
        ("with ~", {
98
70
            "version": "1.8.0~alpha4+bzr356-0ubuntu1",
99
71
            "output": "1.8.0 (alpha4+bzr356)",
100
72
            }),
101
73
        ("without ~", {
102
74
            "version": "1.8.0+bzr356-0ubuntu1",
103
75
            "output": "1.8.0 (+bzr356)",
104
76
            }),
105
77
        ("without ~ or +", {
106
78
            "version": "1.8.0-0ubuntu1",
107
79
            "output": "1.8.0",
108
80
            }),
109
81
    ]
110
82
111
83
    def test__returns_formatted_version(self):
112
84
        self.assertEquals(self.output, version.format_version(self.version))
113
85
114
86
115
87
class TestGetMAASRegionPackageVersion(MAASTestCase):
116
88
117
89
    def test__returns_value_from_global(self):
118
90
        self.patch(version, "MAAS_VERSION", sentinel.maas_version)
119
91
        self.assertIs(
120
92
            sentinel.maas_version, version.get_maas_region_package_version())
121
93
122
94
    def test__calls_get_version_from_apt_if_global_not_set(self):
123
95
        self.patch(version, "MAAS_VERSION", None)
124
96
        mock_apt = self.patch(version, "get_version_from_apt")
125
97
        version.get_maas_region_package_version()
126
98
        self.assertThat(
127
99
            mock_apt, MockCalledOnceWith(version.REGION_PACKAGE_NAME))
128
100
129
101
    def test__calls_format_version_with_version_from_apt(self):
130
102
        self.patch(version, "MAAS_VERSION", None)
131
103
        current_ver = "1.8.0~alpha4+bzr356-0ubuntu1"
132
104
        mock_apt = self.patch(version, "get_version_from_apt")
133
105
        mock_apt.return_value = current_ver
134
106
        mock_format = self.patch(version, "format_version")
135
107
        mock_format.return_value = sentinel.format
136
108
        self.expectThat(
137
109
            version.get_maas_region_package_version(), Is(sentinel.format))
138
110
        self.expectThat(
139
111
            mock_format, MockCalledOnceWith(current_ver))
140
112
141
113
    def test__sets_global_value(self):
142
114
        self.patch(version, "MAAS_VERSION", None)
143
115
        current_ver = "1.8.0~alpha4+bzr356-0ubuntu1"
144
116
        mock_apt = self.patch(version, "get_version_from_apt")
145
117
        mock_apt.return_value = current_ver
146
118
        mock_format = self.patch(version, "format_version")
147
119
        mock_format.return_value = sentinel.format
148
120
        version.get_maas_region_package_version()
149
121
        self.assertIs(sentinel.format, version.MAAS_VERSION)
150
122
151
123
152
124
class TestGetMAASBranch(MAASTestCase):
66
class TestGetMAASBranch(MAASTestCase):
153
125
67
154
126
    def test__returns_None_if_Branch_is_None(self):
68
    def test__returns_None_if_Branch_is_None(self):
155
@@ -139,61 +81,137 @@
156
139
        self.assertIsNone(version.get_maas_branch())
81
        self.assertIsNone(version.get_maas_branch())
157
140
82
158
141
83
202
142
class TestGetMAASVersion(MAASTestCase):
84
class TestExtractVersionSubversion(MAASTestCase):
203
143
85
204
144
    def test__returns_version_from_get_maas_region_package_version(self):
86
    scenarios = [
205
145
        mock_version = self.patch(version, "get_maas_region_package_version")
87
        ("with ~", {
206
146
        mock_version.return_value = sentinel.version
88
            "version": "1.8.0~alpha4+bzr356-0ubuntu1",
207
147
        self.assertIs(sentinel.version, version.get_maas_version())
89
            "output": ("1.8.0", "alpha4+bzr356"),
208
148
90
            }),
209
149
    def test__returns_unknown_if_version_is_empty_and_not_bzr_branch(self):
91
        ("without ~", {
210
150
        mock_version = self.patch(version, "get_maas_region_package_version")
92
            "version": "1.8.0+bzr356-0ubuntu1",
211
151
        mock_version.return_value = ""
93
            "output": ("1.8.0", "+bzr356"),
212
152
        mock_branch = self.patch(version, "get_maas_branch")
94
            }),
213
153
        mock_branch.return_value = None
95
        ("without ~ or +", {
214
154
        self.assertEquals("unknown", version.get_maas_version())
96
            "version": "1.8.0-0ubuntu1",
215
155
97
            "output": ("1.8.0", ""),
216
156
    def test__returns_from_source_and_revno_from_branch(self):
98
            }),
217
157
        mock_version = self.patch(version, "get_maas_region_package_version")
99
    ]
218
158
        mock_version.return_value = ""
100
219
159
        revno = random.randint(1, 5000)
101
    def test__returns_version_subversion(self):
220
160
        mock_branch = self.patch(version, "get_maas_branch")
102
        self.assertEquals(
221
161
        mock_branch.return_value.revno.return_value = revno
103
            self.output, version.extract_version_subversion(self.version))
222
162
        self.assertEquals(
104
223
163
            "from source (+bzr%s)" % revno, version.get_maas_version())
105
224
164
106
class TestVersionTestCase(MAASTestCase):
225
165
107
    """MAASTestCase that resets the cache used by utility methods."""
226
166
class TestGetMAASMainVersion(MAASTestCase):
108
227
167
109
    def setUp(self):
228
168
    def test__returns_main_version_from_package_version_with_space(self):
110
        super(TestVersionTestCase, self).setUp()
229
169
        mock_version = self.patch(version, "get_maas_region_package_version")
111
        self.patch(version, "_cache", {})
230
170
        mock_version.return_value = "1.8.0 (alpha4+bzr356)"
112
231
171
        self.assertEquals("1.8.0", version.get_maas_main_version())
113
232
172
114
class TestGetMAASPackageVersion(TestVersionTestCase):
233
173
    def test__returns_main_version_from_package_version_without_space(self):
115
234
174
        mock_version = self.patch(version, "get_maas_region_package_version")
116
    def test__calls_get_version_from_apt(self):
235
175
        mock_version.return_value = "1.8.0"
117
        mock_apt = self.patch(version, "get_version_from_apt")
236
176
        self.assertEquals("1.8.0", version.get_maas_main_version())
118
        mock_apt.return_value = sentinel.version
237
177
119
        self.expectThat(
238
178
    def test__returns_empty_if_version_is_empty(self):
120
            version.get_maas_package_version(), Is(sentinel.version))
239
179
        mock_version = self.patch(version, "get_maas_region_package_version")
121
        self.expectThat(
240
180
        mock_version.return_value = ""
122
            mock_apt, MockCalledOnceWith(version.REGION_PACKAGE_NAME))
241
181
        self.assertEquals("", version.get_maas_main_version())
123
242
182
124
243
183
125
class TestGetMAASVersionSubversion(TestVersionTestCase):
244
184
class TestGetMAASDocVersion(MAASTestCase):
126
245
127
    def test__returns_package_version(self):
246
128
        mock_apt = self.patch(version, "get_version_from_apt")
247
129
        mock_apt.return_value = "1.8.0~alpha4+bzr356-0ubuntu1"
248
130
        self.assertEquals(
249
131
            ("1.8.0", "alpha4+bzr356"), version.get_maas_version_subversion())
250
132
251
133
    def test__returns_unknown_if_version_is_empty_and_not_bzr_branch(self):
252
134
        mock_version = self.patch(version, "get_version_from_apt")
253
135
        mock_version.return_value = ""
254
136
        mock_branch = self.patch(version, "get_maas_branch")
255
137
        mock_branch.return_value = None
256
138
        self.assertEquals(
257
139
            ("unknown", ""), version.get_maas_version_subversion())
258
140
259
141
    def test__returns_from_source_and_revno_from_branch(self):
260
142
        mock_version = self.patch(version, "get_version_from_apt")
261
143
        mock_version.return_value = ""
262
144
        revno = random.randint(1, 5000)
263
145
        mock_branch = self.patch(version, "get_maas_branch")
264
146
        mock_branch.return_value.revno.return_value = revno
265
147
        self.assertEquals(
266
148
            ("from source (+bzr%s)" % revno, ""),
267
149
            version.get_maas_version_subversion())
268
150
269
151
270
152
class TestGetMAASVersionUI(TestVersionTestCase):
271
153
272
154
    def test__returns_package_version(self):
273
155
        mock_apt = self.patch(version, "get_version_from_apt")
274
156
        mock_apt.return_value = "1.8.0~alpha4+bzr356-0ubuntu1"
275
157
        self.assertEquals(
276
158
            "1.8.0 (alpha4+bzr356)", version.get_maas_version_ui())
277
159
278
160
    def test__returns_unknown_if_version_is_empty_and_not_bzr_branch(self):
279
161
        mock_version = self.patch(version, "get_version_from_apt")
280
162
        mock_version.return_value = ""
281
163
        mock_branch = self.patch(version, "get_maas_branch")
282
164
        mock_branch.return_value = None
283
165
        self.assertEquals("unknown", version.get_maas_version_ui())
284
166
285
167
    def test__returns_from_source_and_revno_from_branch(self):
286
168
        mock_version = self.patch(version, "get_version_from_apt")
287
169
        mock_version.return_value = ""
288
170
        revno = random.randint(1, 5000)
289
171
        mock_branch = self.patch(version, "get_maas_branch")
290
172
        mock_branch.return_value.revno.return_value = revno
291
173
        self.assertEquals(
292
174
            "from source (+bzr%s)" % revno, version.get_maas_version_ui())
293
175
294
176
295
177
class TestGetMAASDocVersion(TestVersionTestCase):
296
185
178
297
186
    def test__returns_doc_version_with_greater_than_1_decimals(self):
179
    def test__returns_doc_version_with_greater_than_1_decimals(self):
300
187
        mock_version = self.patch(version, "get_maas_main_version")
180
        mock_apt = self.patch(version, "get_version_from_apt")
301
188
        mock_version.return_value = "1.8.0"
181
        mock_apt.return_value = "1.8.0~alpha4+bzr356-0ubuntu1"
302
189
        self.assertEquals("docs1.8", version.get_maas_doc_version())
182
        self.assertEquals("docs1.8", version.get_maas_doc_version())
303
190
183
304
191
    def test__returns_doc_version_with_equal_to_1_decimals(self):
184
    def test__returns_doc_version_with_equal_to_1_decimals(self):
307
192
        mock_version = self.patch(version, "get_maas_main_version")
185
        mock_apt = self.patch(version, "get_version_from_apt")
308
193
        mock_version.return_value = "1.8"
186
        mock_apt.return_value = "1.8~alpha4+bzr356-0ubuntu1"
309
194
        self.assertEquals("docs1.8", version.get_maas_doc_version())
187
        self.assertEquals("docs1.8", version.get_maas_doc_version())
310
195
188
311
196
    def test__returns_just_doc_if_version_is_empty(self):
189
    def test__returns_just_doc_if_version_is_empty(self):
314
197
        mock_version = self.patch(version, "get_maas_main_version")
190
        mock_apt = self.patch(version, "get_version_from_apt")
315
198
        mock_version.return_value = ""
191
        mock_apt.return_value = ""
316
199
        self.assertEquals("docs", version.get_maas_doc_version())
192
        self.assertEquals("docs", version.get_maas_doc_version())
317
193
318
194
319
195
class TestVersionMethodsCached(TestVersionTestCase):
320
196
321
197
    scenarios = [
322
198
        ("get_maas_package_version", dict(method="get_maas_package_version")),
323
199
        ("get_maas_version_subversion", dict(
324
200
            method="get_maas_version_subversion")),
325
201
        ("get_maas_version_ui", dict(method="get_maas_version_ui")),
326
202
        ("get_maas_doc_version", dict(method="get_maas_doc_version")),
327
203
        ]
328
204
329
205
    def test_method_is_cached(self):
330
206
        mock_apt = self.patch(version, "get_version_from_apt")
331
207
        mock_apt.return_value = "1.8.0~alpha4+bzr356-0ubuntu1"
332
208
        cached_method = getattr(version, self.method)
333
209
        first_return_value = cached_method()
334
210
        second_return_value = cached_method()
335
211
        # The return value is not empty (full unit tests have been performed
336
212
        # earlier).
337
213
        self.assertNotIn(first_return_value, [b'', u'', None])
338
214
        self.assertEqual(first_return_value, second_return_value)
339
215
        # Apt has only been called once.
340
216
        self.expectThat(
341
217
            mock_apt, MockCalledOnceWith(version.REGION_PACKAGE_NAME))
342
200
218
343
=== modified file 'src/maasserver/utils/version.py'
344
--- src/maasserver/utils/version.py	2015-03-30 17:54:35 +0000
345
+++ src/maasserver/utils/version.py	2015-04-08 15:11:40 +0000
346
@@ -14,7 +14,8 @@
347
14
__metaclass__ = type
14
__metaclass__ = type
348
15
__all__ = [
15
__all__ = [
349
16
    "get_maas_doc_version",
16
    "get_maas_doc_version",
351
17
    "get_maas_version",
17
    "get_maas_version_subversion",
352
18
    "get_maas_version_ui",
353
18
    ]
19
    ]
354
19
20
355
20
import apt_pkg
21
import apt_pkg
356
@@ -29,9 +30,6 @@
357
29
# Initialize apt_pkg.
30
# Initialize apt_pkg.
358
30
apt_pkg.init()
31
apt_pkg.init()
359
31
32
360
32
# Holds the version of maas.
361
33
MAAS_VERSION = None
362
34
363
35
# Name of maas package to get version from.
33
# Name of maas package to get version from.
364
36
REGION_PACKAGE_NAME = "maas-region-controller-min"
34
REGION_PACKAGE_NAME = "maas-region-controller-min"
365
37
35
366
@@ -50,34 +48,16 @@
367
50
        return ""
48
        return ""
368
51
49
369
52
50
372
53
def format_version(version):
51
def extract_version_subversion(version):
373
54
    """Format `version` into a better looking string for the UI."""
52
    """Return a tuple (version, subversion) from the given apt version."""
374
55
    if "~" in version:
53
    if "~" in version:
375
56
        main_version, extra = version.split("~", 1)
54
        main_version, extra = version.split("~", 1)
377
57
        return "%s (%s)" % (main_version, extra.split("-", 1)[0])
55
        return main_version, extra.split("-", 1)[0]
378
58
    elif "+" in version:
56
    elif "+" in version:
379
59
        main_version, extra = version.split("+", 1)
57
        main_version, extra = version.split("+", 1)
381
60
        return "%s (+%s)" % (main_version, extra.split("-", 1)[0])
58
        return main_version, "+" + extra.split("-", 1)[0]
382
61
    else:
59
    else:
402
62
        return version.split("-", 1)[0]
60
        return version.split("-", 1)[0], ''
384
63
385
64
386
65
def get_maas_region_package_version():
387
66
    """Return the dpkg version for `REGION_PACKAGE_NAME`.
388
67
389
68
    Lazy loads the version. Once loaded it will not be loaded again.
390
69
    This is to speed up the call to this method and also to require the
391
70
    region to be restarted to see the new version.
392
71
    """
393
72
    global MAAS_VERSION
394
73
    if MAAS_VERSION is None:
395
74
        MAAS_VERSION = get_version_from_apt(REGION_PACKAGE_NAME)
396
75
        # Possibly this returned an empty string, meaning it's not installed
397
76
        # and no need to call again.
398
77
        if MAAS_VERSION:
399
78
            # It is a valid version so set the correct format.
400
79
            MAAS_VERSION = format_version(MAAS_VERSION)
401
80
    return MAAS_VERSION
403
81
61
404
82
62
405
83
def get_maas_branch():
63
def get_maas_branch():
406
@@ -90,41 +70,62 @@
407
90
        return None
70
        return None
408
91
71
409
92
72
416
93
def get_maas_version():
73
_cache = {}
417
94
    """Return the version string for the running MAAS region."""
74
418
95
    # MAAS is installed from package, return the version string.
75
419
96
    version = get_maas_region_package_version()
76
# A very simply memoize function: when we switch to Django 1.7 we should use
420
97
    if version:
77
# Django's lru_cache method.
421
98
        return version
78
def simple_cache(fun):
422
79
    def wrapped(*args, **kwargs):
423
80
        key = hash(repr(fun) + repr(args) + repr(kwargs))
424
81
        if not key in _cache:
425
82
            _cache[key] = fun(*args, **kwargs)
426
83
        return _cache[key]
427
84
428
85
    wrapped.__doc__ = "%s %s" % (fun.__doc__, "(cached)")
429
86
    return wrapped
430
87
431
88
432
89
@simple_cache
433
90
def get_maas_package_version():
434
91
    """Return the apt version for the main MAAS package."""
435
92
    return get_version_from_apt(REGION_PACKAGE_NAME)
436
93
437
94
438
95
@simple_cache
439
96
def get_maas_version_subversion():
440
97
    """Return a tuple with the MAAS version and the MAAS subversion."""
441
98
    apt_version = get_maas_package_version()
442
99
    if apt_version:
443
100
        return extract_version_subversion(apt_version)
444
99
    else:
101
    else:
445
100
        # Get the branch information
102
        # Get the branch information
446
101
        branch = get_maas_branch()
103
        branch = get_maas_branch()
447
102
        if branch is None:
104
        if branch is None:
448
103
            # Not installed not in branch, then no way to identify. This should
105
            # Not installed not in branch, then no way to identify. This should
449
104
            # not happen, but just in case.
106
            # not happen, but just in case.
468
105
            return "unknown"
107
            return "unknown", ''
469
106
        else:
108
        else:
470
107
            return "from source (+bzr%s)" % branch.revno()
109
            return "from source (+bzr%s)" % branch.revno(), ''
471
108
110
472
109
111
473
110
def get_maas_main_version():
112
@simple_cache
474
111
    """Return the main version for the running MAAS region."""
113
def get_maas_version_ui():
475
112
    # MAAS is installed from package, return the version string.
114
    """Return the version string for the running MAAS region.
476
113
    version = get_maas_region_package_version()
115
477
114
    if version:
116
    The returned string is suitable to display in the UI.
478
115
        if " " in version:
117
    """
479
116
            return version.split(" ")[0]
118
    version, subversion = get_maas_version_subversion()
480
117
        else:
119
    return "%s (%s)" % (version, subversion) if subversion else version
481
118
            return version
120
482
119
    else:
121
483
120
        return ""
122
@simple_cache
466
121
467
122
484
123
def get_maas_doc_version():
123
def get_maas_doc_version():
485
124
    """Return the doc version for the running MAAS region."""
124
    """Return the doc version for the running MAAS region."""
486
125
    main_version = get_maas_main_version()
487
126
    doc_prefix = 'docs'
125
    doc_prefix = 'docs'
489
127
    if not main_version:
126
    apt_version = get_maas_package_version()
490
127
    if apt_version:
491
128
        version, _ = extract_version_subversion(apt_version)
492
129
        return doc_prefix + '.'.join(version.split('.')[:2])
493
130
    else:
494
128
        return doc_prefix
131
        return doc_prefix
495
129
    else:
496
130
        return doc_prefix + '.'.join(main_version.split('.')[:2])
Reviewer	Review Type	Date Requested	Status
Blake Rouse (community)		2015-04-07	Approve on 2015-04-07
Review via email: mp+255357@code.launchpad.net