Code review comment for lp:~rvb/maas/dhcp-multiple-intf

Revision history for this message
Raphaƫl Badin (rvb) wrote :

Thanks for the review!

> A small note: in rc/provisioningserver/dhcp/config.py (starting around line
> 45) you now have...
>
> except KeyError as error:
> raise DHCPConfigError(*error.args)
> except NameError as error:
> raise DHCPConfigError(*error.args)
>
> You can write that as simply:
>
> except (KeyError, NameError) as error:
> raise DHCPConfigError(*error.args)
>

Right, fixed (I think I was a bit tired when I wrote this code ;))

> The big loop in src/maasserver/dhcp.py (starting around line 60) looks like it
> now wants to be a list comprehension, with its body extracted into a separate
> function. But no biggie.

Actually, a list comprehension will be enough to make the code a tad more simple. Fixed.

« Back to merge proposal