Code review comment for lp:~rvb/maas/cmd-line-bug-1190958

Revision history for this message
Gavin Panella (allenap) wrote :

[1]

-        self.stdout.write('\n')
+        # In Django 1.5+, self.stdout.write() adds a newline character at
+        # the end of the message.

Please tell me that Django isn't meddling with the behaviour of
sys.stdout.write()? I assume you mean something else.

[2]

> In other words, my strategy here is to make Django 1.5 the default
> expected behaviour and special case for Django.VERSION < 1.5.

The advantage of Jeroen's idea is that we never need to care, even if
the behaviour changes back again in Django 1.6.

« Back to merge proposal