Merge lp:~rvb/maas/check-commissioning-bug-1084292 into lp:~maas-committers/maas/trunk
Proposed by
Raphaël Badin
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1392 |
Proposed branch: | lp:~rvb/maas/check-commissioning-bug-1084292 |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
110 lines (+38/-23) 2 files modified
src/maasserver/api.py (+17/-15) src/maasserver/tests/test_api.py (+21/-8) |
To merge this branch: | bzr merge lp:~rvb/maas/check-commissioning-bug-1084292 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+137526@code.launchpad.net |
Commit message
Fix the check_commissioning API call: make it available to the logged-in users only and return the changed nodes (which is in accordance with what the docs already say).
To post a comment you must log in.
This branch looks fine.
I found the assert of two constructed tuples on line 70, 82, and 97 odd.
Wouldn't two simple assertions be clearer and simpler?
The one on line 97 would especially benefit from unrolling.