-def get_file(handler, request):
+def get_file_by_name(handler, request):
"""Get a named file from the file storage.
:param filename: The exact name of the file you want to get.
:type filename: string
:return: The file is returned in the response content.
"""
- filename = request.GET.get("filename", None)
- if not filename:
- raise MAASAPIBadRequest("Filename not supplied")
+ filename = get_mandatory_param(request.GET, 'filename')
try:
- db_file = FileStorage.objects.get(filename=filename)
+ db_file = FileStorage.objects.filter(filename=filename).latest('id')
Shouldn't this restrict itself to files without an owner?
Looks good, but I have a couple of questions.
[1]
-def get_file(handler, request): by_name( handler, request):
+def get_file_
"""Get a named file from the file storage.
:param filename: The exact name of the file you want to get. GET.get( "filename" , None) st("Filename not supplied") param(request. GET, 'filename') objects. get(filename= filename) objects. filter( filename= filename) .latest( 'id')
:type filename: string
:return: The file is returned in the response content.
"""
- filename = request.
- if not filename:
- raise MAASAPIBadReque
+ filename = get_mandatory_
try:
- db_file = FileStorage.
+ db_file = FileStorage.
Shouldn't this restrict itself to files without an owner?
[2]
def delete(self, request, filename): or_404( FileStorage, filename=filename)
stored_ file.delete( )
"""Delete a FileStorage object."""
- stored_file = get_object_
+ stored_file = get_object_or_404(
+ FileStorage, filename=filename, owner=request.user)
Should this fall back to deleting files without owner when an
owned file is not found?