Code review comment for lp:~rvb/maas/bug-1070765-hostname

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> One question: should the hostname regex perhaps contain the final dot that
> separates the hostname proper from the domain name? (If so, of course it
> needs to be escaped or it'll match any character).

I don't think so, we want to store only the hostname in that field (in the long run, but we have to cope with the fact that existing installations will have a fqdn in there).

« Back to merge proposal