Code review comment for lp:~rvb/maas/bug-1070765-hostname

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

One question: should the hostname regex perhaps contain the final dot that separates the hostname proper from the domain name? (If so, of course it needs to be escaped or it'll match any character).

Jeroen

review: Approve

« Back to merge proposal