Merge lp:~rvb/maas-test/real-tests into lp:maas-test

[Raphaël Badin]

Add enlistment and commissioning tests.

I left TestMAAS as a mixin and added the two tests inside a separate class named TestInteractiveOneNode. This way, we can reuse the mixin (which takes care of all the set -up) if we want a fully automated (i.e. non interactive) test as well.

[Graham Binns (gmb)]

review: Approve

=== modified file 'maastest/main.py'
--- maastest/main.py	2013-11-19 08:49:07 +0000
+++ maastest/main.py	2013-11-19 11:29:13 +0000
@@ -14,7 +14,9 @@
     "main",
     ]
 
+import httplib
 import inspect
+import json
 import logging
 import sys
 import unittest
@@ -81,23 +83,63 @@
         super(TestMAAS, self).setUp()
         self.addCleanup(self.unify_details)
 
-    def test_dummy(self):
-        # TODO: Placeholder test.  Replace with actual tests.
-        # For now, just hold so you can log into the VM and play with it.
+    def print_connection_details(self):
         print(
-            "\n****** VM RUNNING ON %s.  PRESS ENTER TO SHUT DOWN. ******\n"
+            "\n"
             "URL: http://%s/MAAS/\n"
             "Username: %s\n"
             "Password: %s\n"
             "SSH login: ssh -i ~/.maas-test/vm_ssh_id_rsa %s\n"
             % (
                 self.machine.ip_address(),
-                self.machine.ip_address(),
                 self.maas.admin_user,
                 self.maas.admin_password,
                 self.machine.identity(),
             ))
+
+    def get_node_list(self, status):
+        """Return the list of nodes with the given status."""
+        uri = utils.get_uri('nodes/')
+        response = self.maas.admin_maas_client.get(uri, op="list")
+        self.assertEqual(
+            httplib.OK, response.code, "Failed to get the node list.")
+        nodes = json.loads(response.read())
+        relevant_nodes = [node for node in nodes if node['status'] == status]
+        return relevant_nodes
+
+
+class TestInteractiveOneNode(TestMAAS):
+    """Test if a node is compatible with MAAS.
+
+    This is an interactive test: after MAAS is set up inside a virtual
+    machine, it waits for the user to power up the node under test before
+    trying to enlist and commission it."""
+
+    def test_enlist_node(self):
+        """Enlist node."""
+        # TODO: only print this in debug/verbose mode.
+        self.print_connection_details()
+        print(
+            "Power up the node under test and press enter to proceed "
+            "with the testing.")
         sys.stdin.readline()
+        for retry in utils.retries(delay=10, timeout=10 * 60):
+            nb_enlisted_nodes = len(self.get_node_list(0))  # 0 = 'Declared'.
+            if nb_enlisted_nodes == 1:
+                return
+        self.fail("Failed to enlist node.")
+
+    def test_commission_node(self):
+        """Commission node."""
+        uri = utils.get_uri('nodes/')
+        response = self.maas.admin_maas_client.post(uri, op="accept_all")
+        self.assertEqual(
+            httplib.OK, response.code, "Failed to get accept the node.")
+        for retry in utils.retries(delay=10, timeout=10 * 60):
+            nb_enlisted_nodes = len(self.get_node_list(4))  # 4 = 'Ready'.
+            if nb_enlisted_nodes == 1:
+                return
+        self.fail("Failed to commission node.")
 
 
 def check_kvm_ok():
@@ -126,8 +168,8 @@
         logging.error("Unable to continue without KVM extensions.")
         return 1
 
-    class ConfiguredTestMAAS(TestMAAS):
-        """A configured version of TestMAAS.
+    class ConfiguredTestMAAS(TestInteractiveOneNode):
+        """A configured version of TestInteractiveOneNode.
 
         ConfiguredTestMAAS is a TestMAAS use to configure it by calling
         cls.configure.  We need to configure the class itself and not