> That is a little bit of a quandary over the sources vs source. Since we can
> pass multiple sources at once then the choice is either to assume they are all
> the same component in their source, or pass multiple components. Since we
> generally only process one source at a time in PCJ I am fine with the single
> component here. If we ever do multiple then we'll have to batch overrides by
> source component.
>
> So overall, it looks good - just a couple of things, I'd
> s/sources_component/source_component/g and move the
> DEBIAN_COMPONENT_OVERRIDE_MAP/DEFAULT_OVERRIDE_COMPONENT into the class, I
> don't think it's useful having it at the module level since we want to
> encourage people to use the new method.
Done.
>
> 168 + # getComponentOverride returns the default component namewhen an
>
> Typo "namewhen"
> That is a little bit of a quandary over the sources vs source. Since we can component/ source_ component/ g and move the COMPONENT_ OVERRIDE_ MAP/DEFAULT_ OVERRIDE_ COMPONENT into the class, I
> pass multiple sources at once then the choice is either to assume they are all
> the same component in their source, or pass multiple components. Since we
> generally only process one source at a time in PCJ I am fine with the single
> component here. If we ever do multiple then we'll have to batch overrides by
> source component.
>
> So overall, it looks good - just a couple of things, I'd
> s/sources_
> DEBIAN_
> don't think it's useful having it at the module level since we want to
> encourage people to use the new method.
Done.
> rride returns the default component namewhen an
> 168 + # getComponentOve
>
> Typo "namewhen"
Fixed.
Thanks for the review.