Code review comment for lp:~rvb/launchpad/override-bug-826870

Revision history for this message
Julian Edwards (julian-edwards) wrote :

That is a little bit of a quandary over the sources vs source. Since we can pass multiple sources at once then the choice is either to assume they are all the same component in their source, or pass multiple components. Since we generally only process one source at a time in PCJ I am fine with the single component here. If we ever do multiple then we'll have to batch overrides by source component.

So overall, it looks good - just a couple of things, I'd s/sources_component/source_component/g and move the DEBIAN_COMPONENT_OVERRIDE_MAP/DEFAULT_OVERRIDE_COMPONENT into the class, I don't think it's useful having it at the module level since we want to encourage people to use the new method.

168 + # getComponentOverride returns the default component namewhen an

Typo "namewhen"

Thanks for the change!

review: Approve

« Back to merge proposal