Code review comment for lp:~rvb/launchpad/dsd-api-bug-766158
Revision history for this message
| Raphaël Badin (rvb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Oh, also (lest it be forgotten :):
>
> - assertSameDiffs could use assertContentEqual to avoid sorted() calls, and
> "ds_diff_ws" should instead be named "derived_ds_ws" or something
2, 3, 4 done.
I also refactored my test to pass actual parameters to the api method. (I'd like to have your opinion about passing str(Enum) to the api method though).
I still need to merge db-devel to fix the conflict but I guess it's going to be easier to review my changes *before* I merge db-devel and thus diverge from Steven's branch.