Merge lp:~rvb/launchpad/derivation-ui-fixes into lp:launchpad/db-devel

Proposed by Raphaël Badin
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 10575
Proposed branch: lp:~rvb/launchpad/derivation-ui-fixes
Merge into: lp:launchpad/db-devel
Diff against target: 83 lines (+10/-19)
2 files modified
lib/lp/registry/browser/distroseries.py (+0/-15)
lib/lp/registry/templates/distroseries-localdifferences.pt (+10/-4)
To merge this branch: bzr merge lp:~rvb/launchpad/derivation-ui-fixes
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+61721@code.launchpad.net

Commit message

[r=julian-edwards][bug=783429,783433,783436,783441] Minor UI fixes for derived distros.

Description of the change

Minor UI fixes for derived distros.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/browser/distroseries.py'
--- lib/lp/registry/browser/distroseries.py 2011-05-19 16:05:17 +0000
+++ lib/lp/registry/browser/distroseries.py 2011-05-20 09:43:33 +0000
@@ -989,11 +989,6 @@
989 self.getParentName(multiple_parent_default='parent series'),989 self.getParentName(multiple_parent_default='parent series'),
990 ))990 ))
991991
992 @action(_("Update"), name="update")
993 def update_action(self, action, data):
994 """Simply re-issue the form with the new values."""
995 pass
996
997 @action(_("Sync Sources"), name="sync", validator='validate_sync',992 @action(_("Sync Sources"), name="sync", validator='validate_sync',
998 condition='canPerformSync')993 condition='canPerformSync')
999 def sync_sources(self, action, data):994 def sync_sources(self, action, data):
@@ -1089,11 +1084,6 @@
1089 self.context.displayname,1084 self.context.displayname,
1090 ))1085 ))
10911086
1092 @action(_("Update"), name="update")
1093 def update_action(self, action, data):
1094 """Simply re-issue the form with the new values."""
1095 pass
1096
1097 @action(_("Sync Sources"), name="sync", validator='validate_sync',1087 @action(_("Sync Sources"), name="sync", validator='validate_sync',
1098 condition='canPerformSync')1088 condition='canPerformSync')
1099 def sync_sources(self, action, data):1089 def sync_sources(self, action, data):
@@ -1130,10 +1120,5 @@
1130 self.getParentName(),1120 self.getParentName(),
1131 ))1121 ))
11321122
1133 @action(_("Update"), name="update")
1134 def update_action(self, action, data):
1135 """Simply re-issue the form with the new values."""
1136 pass
1137
1138 def canPerformSync(self, *args):1123 def canPerformSync(self, *args):
1139 return False1124 return False
11401125
=== modified file 'lib/lp/registry/templates/distroseries-localdifferences.pt'
--- lib/lp/registry/templates/distroseries-localdifferences.pt 2011-05-19 17:06:13 +0000
+++ lib/lp/registry/templates/distroseries-localdifferences.pt 2011-05-20 09:43:33 +0000
@@ -47,14 +47,17 @@
47 </th>47 </th>
48 <th tal:condition="view/show_parent_version">48 <th tal:condition="view/show_parent_version">
49 <tal:one_parent condition="view/has_unique_parent">49 <tal:one_parent condition="view/has_unique_parent">
50 <tal:replace replace="view/unique_parent/displayname" /> version50 <a tal:attributes="href view/unique_parent/fmt:url"
51 tal:content="view/unique_parent/displayname">Warty</a> version
51 </tal:one_parent>52 </tal:one_parent>
52 <tal:multiple_parents condition="not: view/has_unique_parent">53 <tal:multiple_parents condition="not: view/has_unique_parent">
53 Parent version54 Parent version
54 </tal:multiple_parents>55 </tal:multiple_parents>
55 </th>56 </th>
56 <th tal:condition="view/show_derived_version">57 <th tal:condition="view/show_derived_version">
57 <tal:replace replace="series_name" /> version</th>58 <a tal:attributes="href context/fmt:url"
59 tal:content="series_name">Deriwarty</a> version
60 </th>
58 <th tal:condition="view/show_parent_packagesets">61 <th tal:condition="view/show_parent_packagesets">
59 Parent package-sets62 Parent package-sets
60 </th>63 </th>
@@ -81,7 +84,8 @@
81 value diff_id;84 value diff_id;
82 id string:field.selected_differences.${diff_id}"/>85 id string:field.selected_differences.${diff_id}"/>
8386
84 <a tal:attributes="href difference/fmt:url" class="toggle-extra"87 <a tal:attributes="href difference/fmt:url"
88 class="js-action toggle-extra"
85 tal:content="src_name">Foo</a>89 tal:content="src_name">Foo</a>
86 </tal:checkbox>90 </tal:checkbox>
87 <tal:clockface condition="python: view.hasPendingSync(difference)">91 <tal:clockface condition="python: view.hasPendingSync(difference)">
@@ -176,7 +180,9 @@
176 </tal:difference>180 </tal:difference>
177 </tbody>181 </tbody>
178 </table>182 </table>
179 <tal:selectable_differences_end183 <tal:navigation_bottom
184 replace="structure differences/@@+navigation-links-lower" />
185 <tal:selectable_differences_end
180 define="widget nocall:view/widgets/selected_differences;186 define="widget nocall:view/widgets/selected_differences;
181 field_name widget/context/__name__;187 field_name widget/context/__name__;
182 error python:view.getFieldError(field_name);">188 error python:view.getFieldError(field_name);">

Subscribers

People subscribed via source and target branches

to status/vote changes: