rvba, is it intentional that this pages uses the same template as +localpackagediffs?
<rvba> danilos: yes
<danilos> rvba, if so, you'd probably want to rename the template so it better indicates what is it about
<rvba> danilos: that's right.
danilos: actually the template name is distroseries-localdifferences.pt. The 3 pages sharing this templates are all used to display local differences ... of different types.
<danilos> rvba, ok, then I guess it's fine to keep the name
<rvba> yep
<danilos> rvba, the branch looks pretty good otherwise, but I have another naming question: I believe it's our practice to name all our view classes as SomethingSomethingView, so it'd be nice to change that as well
s/as well//
rvba, other than that, r=me
From the IRC conversation:
rvba, is it intentional that this pages uses the same template as +localpackagediffs? localdifference s.pt. The 3 pages sharing this templates are all used to display local differences ... of different types. ingView, so it'd be nice to change that as well
<rvba> danilos: yes
<danilos> rvba, if so, you'd probably want to rename the template so it better indicates what is it about
<rvba> danilos: that's right.
danilos: actually the template name is distroseries-
<danilos> rvba, ok, then I guess it's fine to keep the name
<rvba> yep
<danilos> rvba, the branch looks pretty good otherwise, but I have another naming question: I believe it's our practice to name all our view classes as SomethingSometh
s/as well//
rvba, other than that, r=me