Code review comment for lp:~rvb/launchpad/db-distroseries-migrate-owner-to-registrant

Revision history for this message
Stuart Bishop (stub) wrote :

Note to self - don't review when sick.

The patch is actually fine - the patch I thought was conflicting was on Distribution, not DistroSeries.

Please rename the existing index too:

ALTER INDEX distroseries__owner__idx RENAME TO distroseries__registrant__idx;

And while you are there, we can tidy up some old misnamed indexes too:

ALTER INDEX distrorelease_pkey RENAME TO distroseries_pkey;
ALTER INDEX distrorelease_distribution_key RENAME TO distrorelease__distribution__name__key;
ALTER INDEX distrorelease_distro_release_unique RENAME TO distroseries__distribution__id__key;

patch-2208-56-0.sql

review: Approve (db)

« Back to merge proposal