Code review comment for lp:~rvb/launchpad/bug-869221-archindepwidget
Revision history for this message
| Raphaël Badin (rvb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> This branch looks good. Here are a couple of small things I noticed:
>
> It doesn't seem to me that hideError needs the "error" parameter.
>
> The parenthesis around the second argument to .set on line 385 aren't
> necessary. Not that object, I just thought you might like to know.
Thanks for the review Benji!