Code review comment for lp:~rvb/gwacl/media-link

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good.

[1]

+func CreateVirtualHardDiskMediaLink(StorageName, StoragePath string) string {
+    pathComponents := strings.Split(StoragePath, "/")

I think you ought to strip leading and trailing forward-slashes first:

  len(strings.Split("/fred/", "/")) -> 3

review: Approve

« Back to merge proposal