Code review comment for lp:~rvb/gwacl/add-network-config

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 02/07/13 20:44, Raphaël Badin wrote:
> I changed the DisableSSHPasswordAuthentication boolean into a string because the 'omitempty' parameter would remove the field altogether from the serialized XML when it's false. And we *have to* use 'omitempty' because, when the ConfigurationSet object will be of type NetworkConfiguration, we need that field to be omitted.

FWIW, this really is shouting that LinuxProvisioningConfiguration is not
the same as a generic ConfigurationSet at all ... which is why I did it
that way to start with.

« Back to merge proposal