Code review comment for lp:~rvb/gomaasapi/gomaasapi-bug-1384001

Revision history for this message
Ian Booth (wallyworld) wrote :

@Andrew,

The new behaviour in here now matches what goose does. When Openstack's rate limit is exceeded, a 403 response comes back and goose will retry after the time set by the retry-after header. This is independent of what request is being made. I think this is ok given that machine provisioning generally takes a while anyway, and adding in a few retries hopefully won't materially affect the total time. Not that there's not scope to discuss if this could be improved across the board.

« Back to merge proposal