Merge lp:~rsalveti/ubuntu/maverick/qemu-kvm/fix-610742 into lp:ubuntu/maverick/qemu-kvm

Proposed by Ricardo Salveti
Status: Merged
Merge reported by: Dustin Kirkland 
Merged at revision: not available
Proposed branch: lp:~rsalveti/ubuntu/maverick/qemu-kvm/fix-610742
Merge into: lp:ubuntu/maverick/qemu-kvm
Diff against target: 95 lines (+75/-0)
3 files modified
debian/changelog (+10/-0)
debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch (+64/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~rsalveti/ubuntu/maverick/qemu-kvm/fix-610742
Reviewer Review Type Date Requested Status
Serge Hallyn Approve
Review via email: mp+31120@code.launchpad.net

Description of the change

debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch:
 Avoid showing unsupported syscall: 335 for pselect. This was fixed for
 lucid with the pselect patch, but upstream decided not to apply it as it
 it can't guaranty the atomicity for all distros. This patch is backported
 from upstream, as they decided to just remove the warn for it (LP: #610742)

To post a comment you must log in.
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, this looks good. It'll have a very short life-time, but
sounds worth having in the meantime.

Note that I don't have upload rights, so all I can do is say "I
approve" fwiw.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-07-26 15:04:23 +0000
+++ debian/changelog 2010-07-28 07:07:43 +0000
@@ -1,3 +1,13 @@
1qemu-kvm (0.12.4+noroms-0ubuntu7) maverick; urgency=low
2
3 * debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch:
4 Avoid showing unsupported syscall: 335 for pselect. This was fixed for
5 lucid with the pselect patch, but upstream decided not to apply it as it
6 it can't guaranty the atomicity for all distros. This patch is backported
7 from upstream, as they decided to just remove the warn for it (LP: #610742)
8
9 -- Ricardo Salveti de Araujo <ricardo.salveti@canonical.com> Wed, 28 Jul 2010 02:56:04 -0300
10
1qemu-kvm (0.12.4+noroms-0ubuntu6) maverick; urgency=low11qemu-kvm (0.12.4+noroms-0ubuntu6) maverick; urgency=low
212
3 * New patch, arm-ignore-writes-of-perf-reg-cp15-with-crm-12, on ARMv7,13 * New patch, arm-ignore-writes-of-perf-reg-cp15-with-crm-12, on ARMv7,
414
=== added file 'debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch'
--- debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch 2010-07-28 07:07:43 +0000
@@ -0,0 +1,64 @@
1From 9e42382fc14b999126f8cabb32761eb98153fd1b Mon Sep 17 00:00:00 2001
2From: Riku Voipio <riku.voipio@nokia.com>
3Date: Fri, 7 May 2010 12:28:05 +0000
4Subject: [PATCH] linux-user: do not warn for missing pselect6
5
6Libc will fallback gracefully if pselect6 is not available. Thus put
7pselect6 to nowarn until the atomicity issues of the original pselect6
8patch are dealt with.
9
10Signed-off-by: Riku Voipio <riku.voipio@nokia.com>
11Cc: Michael Casadevall <mcasadevall@ubuntu.com>
12Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
13---
14 linux-user/syscall.c | 4 ++++
15 1 files changed, 4 insertions(+), 0 deletions(-)
16
17diff --git a/linux-user/syscall.c b/linux-user/syscall.c
18index bca8f70..8222cb9 100644
19--- a/linux-user/syscall.c
20+++ b/linux-user/syscall.c
21@@ -5268,6 +5268,10 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
22 }
23 break;
24 #endif
25+#ifdef TARGET_NR_pselect6
26+ case TARGET_NR_pselect6:
27+ goto unimplemented_nowarn;
28+#endif
29 case TARGET_NR_symlink:
30 {
31 void *p2;
32--
331.7.1
34
35From 7270547fe8d0d2c1d13fee592042208d4a82f73a Mon Sep 17 00:00:00 2001
36From: Michael Casadevall <mcasadevall@ubuntu.com>
37Date: Fri, 26 Mar 2010 15:25:10 +0000
38Subject: [PATCH] linux-user: Add the syscall id for pselect6 on ARM
39
40As this is now supported in newer linux kernels.
41
42Signed-off-by: Michael Casadevall <mcasadevall@ubuntu.com>
43Signed-off-by: Riku Voipio <riku.voipio@nokia.com>
44Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
45---
46 linux-user/arm/syscall_nr.h | 2 +-
47 1 files changed, 1 insertions(+), 1 deletions(-)
48
49diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
50index b1db341..79a216a 100644
51--- a/linux-user/arm/syscall_nr.h
52+++ b/linux-user/arm/syscall_nr.h
53@@ -338,7 +338,7 @@
54 #define TARGET_NR_readlinkat (332)
55 #define TARGET_NR_fchmodat (333)
56 #define TARGET_NR_faccessat (334)
57- /* 335 for pselect6 */
58+#define TARGET_NR_pselect6 (335)
59 /* 336 for ppoll */
60 #define TARGET_NR_unshare (337)
61 #define TARGET_NR_set_robust_list (338)
62--
631.7.1
64
065
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-07-26 15:04:23 +0000
+++ debian/patches/series 2010-07-28 07:07:43 +0000
@@ -5,3 +5,4 @@
5scm-rights-fd.patch5scm-rights-fd.patch
6fix-multiboot-compilation.patch6fix-multiboot-compilation.patch
7Detect-and-use-GCC-atomic-builtins-for-locking.patch7Detect-and-use-GCC-atomic-builtins-for-locking.patch
8linux-user-do-not-warn-for-missing-pselect6.patch

Subscribers

People subscribed via source and target branches