Code review comment for lp:~rsalveti/phablet-extras/ofono-imei-revision

A couple comments...

1. Since it's safe to call g_free() with a NULL pointer, the general approach I've seen in the ofono code is to just call it and not check for pointers. This feels wrong to me, but that seems to be the general convention for glib based code ( including the rest of ofono ).

So, could you remove line 43 & 96?

2. The second comment is due to the overly complicated tracing functions. On lines 60 & 122, you should call g_print_request_no_args(), otherwise you could end up with incorrect output from a previous request/response.

As part of our major re-factor, I have a plan to fix this by moving the g_ril_print_request() calls into g_ril_send *and* I will also change the macros to clear print_buf after print_request/print_response or print_unsol() calls.