Code review comment for lp:~rryan/mixxx/atomic-co

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

> For the record, I completely agree. (This was one thing that annoyed me during the controller subsystem rewrite, and it remains responsible for inconsistencies between straight XML-mapped controls and those set from script as well as code duplication to minimize them.)

Yea, it's been this way since Mixxx 1.0 and it's a huge hack.

If we converted everything to have one parameter space then I think every control should have a setParameter()/getParameter() method that allows you to set the value in parameter space. I don't want to work on this (killing MIDI/widget parameter space) until we've merged this though. This branch diff is already quite large.

« Back to merge proposal