Code review comment for lp:~rryan/mixxx/atomic-co

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

> How much rewriting is this going to require, such as for my master_sync branch which has a lot of controlobject fiddliness?

For this branch, if we keep the separation between valueChanged and valueChangedFromEngine then it shouldn't need many/any changes.

For engine-control-refactor, the changes will be significant (hopefully mostly cosmetic though, the logic will need a review). I suggest getting master_sync merged before engine-control-refactor :).

« Back to merge proposal