Code review comment for lp:~rpadovani/webbrowser-app/settings-page
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Bill raised some good points, thanks for addressing them so quickly.
Following up on this, I think we should validate the contents of the homepage text field before saving them. For example, if I type something that is clearly not a URL (e.g. "foo bar baz"), it shouldn’t override the current value.
For this I think you’ll need to move the looksLikeAUrl() function from AddressBar.qml to urlManagement.js. We probably want to enable the "Save" button conditionnally only when the contents of the text field is a valid URL.