Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > Could I suggest Google, Bing, Yahoo and DuckDuckGo?
>
> Yeah, I’d like to add more search engines to the list by default, but that
> will require more work as we would probably need to monitor several folders
> (system-wide + locally installed by the user), so let’s do that separately.

Until we enable that (and we ensure that at least two options are shipped by default), we’ll need to hide the Search Engines entry in the settings if we detect that the number of xml files in the searchengines/ folder is < 2. So the FolderListModel instance needs to move a few levels higher in the hierarchy and gain an id in order to be referenced from various places in the SettingsPage component.

review: Needs Fixing

« Back to merge proposal