Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Olivier Tilloy (osomon) wrote :

Indeed changing an option in the settings page breaks the initial property binding, and thus the properties are not reset in the settings page (even though their values are correctly reset).

We need to tackle this differently: the SettingsPage object needs a 'settings' property, which will be the shared Settings instance, and changing values there will update the properties on the shared instance directly, instead of going through an additional indirection. I have update my qt-labs-settings branch to allow that, please merge it into yours.
As well as getting rid of most of the top-level properties on the SettingsPage component (except historyModel, which is still needed), this will also allow us to remove the restoreDefaults signal.

review: Needs Fixing

« Back to merge proposal