Code review comment for lp:~rpadovani/webbrowser-app/no-duplicates-address-bar

Revision history for this message
Olivier Tilloy (osomon) wrote :

Counting how many items you’ve added from one given model is okay. What’s not ok is to check that with hardcoded assertions such as:

    model.icon !== 'non-starred'

because you make assumptions on the models used to populate the suggestions.

« Back to merge proposal