webbrowser-app

Code review comment for lp:~rpadovani/webbrowser-app/addressBarFullWidth

  1. addressBarFullWidth
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

There are several build failures that need fixing:

  tests/autopilot/webbrowser_app/tests/test_addressbar_states.py:51:44: F821 undefined name 'Eventually'
  tests/autopilot/webbrowser_app/tests/test_addressbar_states.py:51:55: F821 undefined name 'Equals'

and

  src/app/webbrowser/AddressBar.qml:20:1: module "Ubuntu.Keyboard" is not installed
     import Ubuntu.Keyboard 0.1

review: Needs Fixing
Reply

« Back to merge proposal