Code review comment for lp:~rpadovani/webbrowser-app/addressBarFullWidth

Revision history for this message
Olivier Tilloy (osomon) wrote :

The change looks good, but it breaks a large number of autopilot tests in at least two different ways:

 - Some tests focus the address bar and then try to open the drawer, but the button is hidden. Some of these tests can simply be removed, and some will need to be rewritten to account for the new behaviour.

 - A number of tests focus the address bar and then try to click the clear button, but since the width of the address bar is animated, in the time it takes for the cursor to move to where the clear button was, it has moved away, and the click happens outside the button. This is mostly an issue on desktop, but could potentially affect touch devices as well. We need a way for the autopilot tests to wait until the address bar has finished expanding before clicking the clear button.

review: Needs Fixing

« Back to merge proposal