Ubuntu Calendar App

Code review comment for lp:~rpadovani/ubuntu-calendar-app/1240152

  1. 1240152
  2. Merge into trunk
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

6 Row{
7 width: parent.width
8 - spacing: units.gu(1)
9 + spacing: units.gu(1) + (frequencyLabel.width - remindLabel.width) // This is to align right the optionSelector

Hi, I think we should use Item here instead of Row, and use anchoring to align OptionSelector to right and we can set width to OptionSelector, as you are doing already.

And can get rid of following

spacing: units.gu(1) + (frequencyLabel.width - remindLabel.width) // This is to align right the optionSelector

« Back to merge proposal