Code review comment for lp:~rpadovani/ubuntu-calendar-app/1231136

Revision history for this message
Charles Kerr (charlesk) wrote :

I see that this MP is blocked awaiting my review.

The approach looks sane and the coding is fine; I'm happy enough to Approve on that level.

From an indicator-datetime perspective, I don't have much of substance to add to this review. The indicator doesn't know or care what the contents of the calendar:/// url are as long as it can be fetched from EDS and dispatched via url-dispatcher.

review: Approve

« Back to merge proposal