Merge lp:~rpadovani/ubuntu-calculator-app/waitUntilOskIsHidden into lp:ubuntu-calculator-app

Proposed by Riccardo Padovani
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 149
Merged at revision: 152
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/waitUntilOskIsHidden
Merge into: lp:ubuntu-calculator-app
Diff against target: 44 lines (+4/-8)
1 file modified
app/ubuntu-calculator-app.qml (+4/-8)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/waitUntilOskIsHidden
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+254875@code.launchpad.net

Commit message

Wait until osk keyboard is hidden before showing our custom keyboard

Description of the change

Wait until osk keyboard is hidden before showing our custom keyboard

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Tested this on my krillin and it works well!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml 2015-03-30 08:33:45 +0000
+++ app/ubuntu-calculator-app.qml 2015-04-06 12:49:50 +0000
@@ -34,7 +34,7 @@
34 // Removes the old toolbar and enables new features of the new header.34 // Removes the old toolbar and enables new features of the new header.
35 useDeprecatedToolbar: false;35 useDeprecatedToolbar: false;
36 automaticOrientation: true36 automaticOrientation: true
37 anchorToKeyboard: true37 anchorToKeyboard: textInputField.visible ? false : true
3838
39 width: units.gu(40);39 width: units.gu(40);
40 height: units.gu(70);40 height: units.gu(70);
@@ -73,11 +73,6 @@
73 // If it is set to false, then editing will be invoked73 // If it is set to false, then editing will be invoked
74 property bool deleteSelectedCalculation: true;74 property bool deleteSelectedCalculation: true;
7575
76 Connections {
77 id: oskKeyboard
78 target: Qt.inputMethod
79 }
80
81 /**76 /**
82 * The function calls the Formula.deleteLastFormulaElement function and77 * The function calls the Formula.deleteLastFormulaElement function and
83 * place the result in right vars78 * place the result in right vars
@@ -508,6 +503,7 @@
508 anchors {503 anchors {
509 top: header.bottom504 top: header.bottom
510 bottom: parent.bottom505 bottom: parent.bottom
506 bottomMargin: textInputField.visible ? 0 : -keyboardLoader.height
511 left: parent.left507 left: parent.left
512 right: parent.right508 right: parent.right
513 }509 }
@@ -635,9 +631,9 @@
635 Loader {631 Loader {
636 id: keyboardLoader632 id: keyboardLoader
637 width: parent.width633 width: parent.width
638 visible: textInputField.visible && !oskKeyboard.visible
639 source: scrollableView.width > scrollableView.height ? "ui/LandscapeKeyboard.qml" : "ui/PortraitKeyboard.qml"634 source: scrollableView.width > scrollableView.height ? "ui/LandscapeKeyboard.qml" : "ui/PortraitKeyboard.qml"
640 opacity: ((y + height) >= scrollableView.contentY) && (y <= (scrollableView.contentY + scrollableView.height)) ? 1 : 0635 opacity: ((y + height) >= scrollableView.contentY) &&
636 (y <= (scrollableView.contentY + scrollableView.height)) ? 1 : 0
641 }637 }
642 }638 }
643 }639 }

Subscribers

People subscribed via source and target branches